feat(ble): add typed listen_gear/listen_ui_desire broadcast listeners#89
Merged
Conversation
VehicleStatus.gear/uiDesire (added in the app-recovered proto mirror) were only reachable via the untyped listen_broadcast fallback. Add the two typed listeners following the existing scalar-enum listener pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
VehicleStatus.gear/uiDesireinto the vcsec proto but left them reachable only through the untypedlisten_broadcastfallback - its own body flagged this as a known gap.listen_gear/listen_ui_desiretoBroadcastListeners(tesla_fleet_api/tesla/vehicle/broadcast.py), following the existing scalar-enum listener pattern (listen_vehicle_lock_state/listen_vehicle_sleep_status/listen_user_presence): both fields have no proto3 presence tracking, so they fire on everyVehicleStatusbroadcast with the zero-value default when unset.tests/test_ble_broadcast_listeners.pycover the typed-value and default-value (absent-field) cases for both listeners.docs/bluetooth_vehicles.md's listener table and always-fires note.